Skip to content

Symbolic sympy#272

Closed
chappiewuzefan wants to merge 10 commits intomainfrom
symbolic_sympy
Closed

Symbolic sympy#272
chappiewuzefan wants to merge 10 commits intomainfrom
symbolic_sympy

Conversation

@chappiewuzefan
Copy link
Copy Markdown

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 17, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 7b30ce4
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/64bf6ca25d9ee10008b63654
😎 Deploy Preview https://deploy-preview-272--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chappiewuzefan
Copy link
Copy Markdown
Author

@HumphreyYang @HengchengZhang please review ~ many thanks in advance

@Smit-create
Copy link
Copy Markdown
Member

@chappiewuzefan If resolving conflicts look hard, just do the following:

  1. Revert all the 3 commits.
  2. Reset(rebase) your branch to be the same as main branch.
  3. Copy the sympy file from your PR (which is here online) and commit it.
  4. Force push on this branch.

Please let me know if you need help from me in doing this.

@chappiewuzefan
Copy link
Copy Markdown
Author

@chappiewuzefan If resolving conflicts look hard, just do the following:

  1. Revert all the 3 commits.
  2. Reset(rebase) your branch to be the same as main branch.
  3. Copy the sympy file from your PR (which is here online) and commit it.
  4. Force push on this branch.

Please let me know if you need help from me in doing this.

done, please have a look ~

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 18, 2023

@HengchengZhang
Copy link
Copy Markdown
Member

Hi @chappiewuzefan, I've made some changes and please have a loot at them.

@HumphreyYang
Copy link
Copy Markdown
Member

HumphreyYang commented Jul 19, 2023

Many thanks @chappiewuzefan for the great work! Please kindly check my comments above.

There are some rules that we follow across lectures to maintain a consistent style. If you are not sure how to improve some of the comments I made, you can always open up a lecture and have a look at how it was written or ping me when you need some help. I think the lecture on scipy can be a good reference: https://python-programming.quantecon.org/scipy.html.

@chappiewuzefan
Copy link
Copy Markdown
Author

@HumphreyYang Thanks for your comments! Please have a look again

Copy link
Copy Markdown
Member

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @chappiewuzefan for the updates. Great work!

I will make these changes and iterate from here : )

width: 10%
---
# Simplify an expression
simplified_expr = simplify(expr)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean simplify(eq)?

Comment on lines +35 to +40
from sympy import symbols, init_printing
from sympy import Eq, solve
from sympy import simplify
from sympy import limit
from sympy import diff
from sympy import integrate
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can simply use from sympy import *

@HumphreyYang
Copy link
Copy Markdown
Member

This PR has been migrated to QuantEcon/lecture-python-programming#284.

@HumphreyYang HumphreyYang deleted the symbolic_sympy branch July 25, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants