Conversation
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @mmcky , I just finished updating the subtitles in the advanced lecture series using Claude Code and I generate the instructions for github copilot to review all these changes. But it seems that I cannot ask copilot to do the reviews, i.e., I didn't find copilot in the assignee list. For orth_proj.md I left the change on purpose to not mix with the other PR. I'll update the orth_proj in the other PR Best, |
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a large-scale conversion of all subtitles in lecture markdown files from title case to sentence case capitalization. The change affects headings marked with ##, ###, and #### across 54 lecture files, where only the first letter of the first word should be capitalized while preserving proper names, technical terms, and acronyms.
Key changes include:
- Systematic conversion from title case (e.g., "The Density Case") to sentence case (e.g., "The density case")
- Preservation of proper names like Ramsey, Bellman, Markov, Nash, etc.
- Preservation of technical acronyms like ARMA, CRRA, LQ, DP, etc.
Reviewed Changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| un_insure.md | Updated 8 subtitles to sentence case while preserving "Shavell and Weiss" proper names |
| troubleshooting.md | Converted 2 subtitles including "Fixing your local environment" and "Reporting an issue" |
| tax_smoothing_3.md | Updated 3 subtitles including technical terms like "Roll-over risk" |
| tax_smoothing_2.md | Converted 5 subtitles while preserving proper names and technical terms |
| tax_smoothing_1.md | Updated 3 subtitles including "Public finance questions" and "Barro model" |
| stationary_densities.md | Converted 9 subtitles including technical terms and method names |
| smoothing_tax.md | Updated 6 subtitles preserving technical terms and proper names |
| smoothing.md | Converted 11 subtitles including model specifications and market structure |
| rosen_schooling_model.md | Updated 3 subtitles including framework references |
| robustness.md | Converted 15 subtitles including mathematical and technical concepts |
mmcky
left a comment
There was a problem hiding this comment.
@longye-tian thanks for putting this PR together -- just some very minor questions. Then we can merge.
Co-authored-by: Matt McKay <mmcky@users.noreply.github.com>
Hi @mmcky , Thank you for your review and suggestions. Just resolved them. Best, |
reference to issue #237
GitHub Copilot Review Instructions for Subtitle Capitalization Changes
Overview
Review a large-scale change that converts all subtitles (headings marked with
##,###,####) in lecture markdown files from title case to sentence case, where only the first letter of the first word should be capitalized.Note orth_proj.md is not changed on purpose. So you can skipped this one
What to Check
1. Verify Sentence Case Conversion
## The density case,### Computing stationary densities,## A model with restructuring## The Density Case,### Computing Stationary Densities,## A Model with Restructuring2. Ensure Proper Names Remain Capitalized
Check that the following proper names maintain their capitalization:
## The Ramsey problem✅ (Ramsey is a proper name)3. Preserve Technical Terms and Acronyms
Verify these remain fully capitalized:
### ARMA processes✅,## Discrete DPs✅4. Special Markdown Syntax Preservation
Ensure MyST markdown index directives are handled correctly:
### {index}\Spectral analysis <single: Spectral Analysis>`` ✅5. Check for Consistency Issues
Look for:
## A dead end✅## a dead end❌## Word Wordwhere the second word isn't a proper name6. Verify No Code Blocks Were Modified
Ensure changes were NOT made to:
#or##)7. Edge Cases to Verify
## Roll-over risk✅ (not "Roll-Over Risk")## Model 1 (complete markets)✅## Appendix: algorithms✅ (word after colon follows same rule)## One- and two-period bonds but no restructuring✅Specific Patterns to Flag as Issues
Title Case Remnants: Any heading where multiple words are capitalized (unless proper names/acronyms)
## Public Finance Questions## Public finance questionsOver-lowercase: Proper names or acronyms that were incorrectly lowercased
## The ramsey problem## The Ramsey problemInconsistent Treatment: Same term treated differently in different places
Broken Markdown: Any heading that might have been corrupted during editing
Files to Pay Special Attention To
Focus extra attention on these files which had many changes:
hs_recursive_models.md(42+ subtitle changes)opt_tax_recur.md(26+ subtitle changes)discrete_dp.md(24+ subtitle changes)dyn_stack.md(23+ subtitle changes)arma.mdExpected Outcome
All 54 lecture markdown files should have:
Review Command Suggestions
Summary of Changes
fix-lecture-subtitle-capitalizationQuick Validation Checklist