Conversation
mmcky
reviewed
Oct 9, 2022
Contributor
mmcky
left a comment
There was a problem hiding this comment.
thanks @HumphreyYang this is looking great. If you could just add a new line after the two directives that don't have them -- this is good to 🚀
| This is peculiar, so make sure you are careful in working with the log normal distribution. | ||
|
|
||
| ``` | ||
| Here is some code that tackles these tasks |
Contributor
There was a problem hiding this comment.
@HumphreyYang super picky I know but I find it helpful to have a newline space after every directive -- make it a bit clearer to read the file.
Member
Author
There was a problem hiding this comment.
@mmcky Thanks for the kind style advice. It does look better with directives separated out from the text. I will keep this in mind. Could you have a quick look at the latest commits in both repos to see if it is what you expected?
Many thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mmcky,
This resolves #122. Could you please merge it if it looks good to you?
Many thanks.