Skip to content

Conversation

@AlexCatarino
Copy link
Member

@AlexCatarino AlexCatarino commented Jul 23, 2018

Description

Includes memory leak fix (QuantConnect/pythonnet@c6db866 and QuantConnect/pythonnet@bec9563)

Related Issue

Closes #2288 #2399 #2488 #2568

Requires Documentation Change

No.

How Has This Been Tested?

Ran BasicTemplateAlgorithm.py in Windows, Linux and macOS.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

@mchandschuh
Copy link
Contributor

NOTE: This update also needs to be applied to other solutions.

@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from 5eb4690 to f110196 Compare July 24, 2018 23:02
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from e762e04 to bd443f9 Compare August 21, 2018 22:48
Copy link
Member

@jaredbroad jaredbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing PandasConverter test

@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch 4 times, most recently from fbf3d6b to 476c9b1 Compare August 27, 2018 17:28
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch 2 times, most recently from 89f87a4 to e99f6d2 Compare August 28, 2018 11:45
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch 2 times, most recently from ec3a516 to ab45b57 Compare September 15, 2018 10:26
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from ab45b57 to 6a6d34c Compare September 24, 2018 18:45
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from 6a6d34c to 228ca13 Compare October 1, 2018 20:38
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from 228ca13 to febd357 Compare October 26, 2018 18:03
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from febd357 to 6fc10fa Compare November 8, 2018 11:15
Includes memory leak fix (QuantConnect/pythonnet@c6db866 and QuantConnect/pythonnet@bec9563)

- Fix python version to 3.6.6 (avoid updating to 3.7)
- Fix numpy version to 1.14.5 (tensorflow requirement)

- Adds py-earth python package (closes QuantConnect#2399).
@AlexCatarino AlexCatarino force-pushed the bug-2288-pythonnet-memory-leak branch from 6fc10fa to 623dec7 Compare December 7, 2018 09:37
Websocket leaks fixed
@jaredbroad jaredbroad merged commit 86807d3 into QuantConnect:master Dec 19, 2018
@AlexCatarino AlexCatarino deleted the bug-2288-pythonnet-memory-leak branch December 19, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add seaborn library Python library request for rauth Add py-earth library Pythonnet Converter is leaking memory

3 participants