fix: Colors can be stringified with expontential alphas, but cannot b…#66
fix: Colors can be stringified with expontential alphas, but cannot b…#66Qix- merged 8 commits intoQix-:masterfrom
Conversation
| /** | ||
| * scientific-notation regexp | ||
| * [+-]?(?=\.\d|\d)(?:0|[1-9]\d*)?(?:\.\d*)?(?:[eE][+-]?\d+)? | ||
| */ |
There was a problem hiding this comment.
This comment is unnecessary.
| /** | |
| * scientific-notation regexp | |
| * [+-]?(?=\.\d|\d)(?:0|[1-9]\d*)?(?:\.\d*)?(?:[eE][+-]?\d+)? | |
| */ |
|
There's a compatibility issue. |
|
That's fine, |
Qix-
left a comment
There was a problem hiding this comment.
Can you add tests for decimal notations as well? E.g. 127.88e4, 0.2e3, .1e-4, etc. Right now only 1e.. is being tested.
|
I wanted to save the scientific notation regular expression in a variable (and then write a test case), and pass it to new Regexp to concatenate it with the previous regular expression, but it was a lot of escaping |
Qix-
left a comment
There was a problem hiding this comment.
Sorry to keep nitting but also add them for hsl too please since they're two separate regexes.
|
Sorry, my food arrived right as I published and I got sidetracked. Quesadillas take priority in my life. Thanks for the PR, published as |
dink42
left a comment
There was a problem hiding this comment.
- Sorry if i destoy your fixes! Tell me if im totally lost, otherwise thanks!
bug source