Skip to content

feat(modules): add duffel bag check#645

Merged
ChatDisabled merged 1 commit into
Qbox-project:mainfrom
5hahfivem:main
Feb 9, 2025
Merged

feat(modules): add duffel bag check#645
ChatDisabled merged 1 commit into
Qbox-project:mainfrom
5hahfivem:main

Conversation

@5hahfivem

Copy link
Copy Markdown
Contributor

Description

This pull request adds a feature to check if a player is wearing a duffel bag.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@Manason Manason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use cases for this? It seems pretty specific to be in lib. Are we going to end up with 100s of functions to check if they are wearing x model?

@5hahfivem

Copy link
Copy Markdown
Contributor Author

Currently have it running on my bank robbery, back items. Anything that would realistically require a duffel bag, I did it for myself, but I PR'ed it since the iswearinggloves ft is handy, with the use cases for a duffel bag requirement I thought it to be equally as useful for others.

@FjamZoo

FjamZoo commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

I don't think this belongs in a "core", it just ends up having a lot of bloated functions.

Even the "glove" checks dosn't belong in the core and should be moved to somewhere like Evidence.

@Manason Manason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit on the fence about whether this makes sense, but it is in the same category as gloves, so unless we can think of a better place, it could be useful to many scripts to have this and therefore it makes sense to be in core.

@ChatDisabled ChatDisabled merged commit 7bb373c into Qbox-project:main Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants