Skip to content

fix(shared): clear deprecated tables#614

Merged
solareon merged 1 commit into
mainfrom
clear-deprecated-tables
Oct 31, 2024
Merged

fix(shared): clear deprecated tables#614
solareon merged 1 commit into
mainfrom
clear-deprecated-tables

Conversation

@mafewtm

@mafewtm mafewtm commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

Description

Clears the deprecated shared tables in order to prevent confusion. Currently a common question is "Why doesn't my armor work?". It's asked not knowing that the two old QB armors are no longer supported but are still in the items table.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@Manason Manason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to delete these, I think we need to also replace the default ox_inventory data files in the recipe to contain the same items

@mafewtm

mafewtm commented Oct 31, 2024

Copy link
Copy Markdown
Contributor Author

If we're going to delete these, I think we need to also replace the default ox_inventory data files in the recipe to contain the same items

The reason to delete these is because the vast majority of these items are unused. I mean if its absolutely necessary we could create a default list of whatever.

@Manason

Manason commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

If we're going to delete these, I think we need to also replace the default ox_inventory data files in the recipe to contain the same items

The reason to delete these is because the vast majority of these items are unused. I mean if its absolutely necessary we could create a default list of whatever.

Ok sounds good. Just need to be mindful as we rely on items in other scripts to add them to the recipe

@solareon solareon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out with the crust!

@solareon solareon merged commit 2c6d7dc into main Oct 31, 2024
@solareon solareon deleted the clear-deprecated-tables branch October 31, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants