Skip to content

fix(server/events): remove threads from handler#583

Merged
Manason merged 3 commits into
mainfrom
fix-statebag-threads
Sep 25, 2024
Merged

fix(server/events): remove threads from handler#583
Manason merged 3 commits into
mainfrom
fix-statebag-threads

Conversation

@solareon

Copy link
Copy Markdown
Contributor

Description

Previous fix didn't scale properly to higher player counts. This sets the metadata prior to the statebag preventing infinite recursion

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@solareon solareon requested a review from Manason September 25, 2024 16:18
@solareon

Copy link
Copy Markdown
Contributor Author

Fixes #578

@D4isDAVID D4isDAVID left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fine when testing.

@rust1co

rust1co commented Sep 25, 2024

Copy link
Copy Markdown

Tested and Ok, Thanks Solareon

@Manason Manason merged commit 07528de into main Sep 25, 2024
@Manason Manason deleted the fix-statebag-threads branch September 25, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants