refactor(character): Use tutorial natives instead of manual bucket setting#480
Merged
Conversation
26d1d3c to
e2e5810
Compare
ghost
approved these changes
Oct 4, 2024
Manason
suggested changes
Oct 4, 2024
Manason
left a comment
Contributor
There was a problem hiding this comment.
Blocking on testing to be confirmed (in a multi-client environment)
Contributor
|
Tested by @D4isDAVID and appears to work as expected |
Manason
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Routing buckets may overlap. The natives do a better job of hiding the characters. This is similar to #473 but moves the tutorial end to the
QBCore:Client:OnPlayerLoadedevent to end the tutorial session with the appropriate native.Additionally it only calls the tutorial session start one time if somehow the choosecharacter() function got called twice without being disabled cause who knows if that works right.
NOTE: I have NOT tested this. Do not merge without extensive testing in a multiplayer environment.
Checklist