Skip to content

Update Korean #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emako merged 11 commits into from
Jul 23, 2025
Merged

Update Korean #1710

emako merged 11 commits into from
Jul 23, 2025

Conversation

@VenusGirl
Copy link
Contributor

@VenusGirl VenusGirl commented Jul 22, 2025 •
edited by sourcery-ai bot
Loading

Update Korean

Summary by Sourcery

Enhancements:

  • Revise Korean translations across all QuickLook plugin components and the main QuickLook application

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 22, 2025 •
edited
Loading

Reviewer's Guide

This PR updates Korean translations across all QuickLook plugin viewers and the core plugin by revising existing entries, adding new ones, removing obsolete keys, and standardizing formatting.

File-Level Changes

Change Details Files
Korean translation updates across all components
  • Revised existing Korean strings for accuracy and consistency
  • Added translations for newly introduced keys
  • Removed obsolete entries no longer in use
  • Standardized punctuation and formatting in translation values
 QuickLook.Plugin/QuickLook.Plugin.AppViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.CLSIDViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.ELFViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.FontViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.OfficeViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.PEViewer/Translations.config
QuickLook.Plugin/QuickLook.Plugin.TextViewer/Translations.config
QuickLook/Translations.config
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 22, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VenusGirl - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@emako emako self-assigned this Jul 22, 2025
@emako emako requested a review from Copilot July 22, 2025 16:46
Copilot AI reviewed Jul 22, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates and enhances Korean language translations for the QuickLook application and all its plugins. The changes include migrating from the specific ko-KR locale tag to the more general ko tag, revising existing translations for better clarity and consistency, and adding missing Korean translations across multiple plugin components.

Key changes include:

  • Standardization of locale identifier from ko-KR to ko
  • Comprehensive translation updates for improved Korean language support
  • Addition of missing Korean translations in plugins that previously lacked them

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
QuickLook/Translations.config Updates main application Korean translations with locale tag change and revised text
QuickLook.Plugin/QuickLook.Plugin.TextViewer/Translations.config Changes locale tag and adds missing editor menu translations
QuickLook.Plugin/QuickLook.Plugin.PEViewer/Translations.config Adds new Korean translations for PE file viewer labels
QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Translations.config Adds Korean translations for PDF password dialog
QuickLook.Plugin/QuickLook.Plugin.OfficeViewer/Translations.config Adds Korean translations for recycle bin functionality
QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Translations.config Updates WebView2 message and changes locale tag
QuickLook.Plugin/QuickLook.Plugin.FontViewer/Translations.config Adds Korean sample text for font preview
QuickLook.Plugin/QuickLook.Plugin.ELFViewer/Translations.config Adds Korean translations for ELF file viewer labels
QuickLook.Plugin/QuickLook.Plugin.CLSIDViewer/Translations.config Moves and updates Korean translations with minor text improvements
QuickLook.Plugin/QuickLook.Plugin.AppViewer/Translations.config Adds comprehensive Korean translations for application viewer labels
Comments suppressed due to low confidence (1)

QuickLook/Translations.config:121

  • The translation '브라우저 {0}' uses '브라우저' (browser) instead of '열기' (open) or '찾아보기' (browse), which may be confusing since this appears to be about opening/browsing folders, not web browsing.
    <MW_BrowseFolder>브라우저 {0}</MW_BrowseFolder>

@VenusGirl
Update QuickLook.Plugin/QuickLook.Plugin.CLSIDViewer/Translations.config
f6ba2a8 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@emako emako merged commit a4d118e into QL-Win:master Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Copilot code review Copilot Copilot left review comments

Assignees

@emako emako

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VenusGirl @emako