Skip to content

Fix groups#691

Merged
Lulalaby merged 3 commits intoPycord-Development:masterfrom
Dorukyum:fix-groups
Jan 4, 2022
Merged

Fix groups#691
Lulalaby merged 3 commits intoPycord-Development:masterfrom
Dorukyum:fix-groups

Conversation

@Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jan 3, 2022

Summary

Fixes issues with groups.

  • Allows not passing the name argument of the bot.group decorator.
  • Fixes an error with groups not having cooldown/max concurrency attributes.
  • Makes Group not inherit from Option since the required attributes are being set now.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (rebase) January 4, 2022 00:45
@Lulalaby Lulalaby added bug Something isn't working Merge with rebase priority: high High Priority labels Jan 4, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 4, 2022
@Lulalaby Lulalaby requested a review from ChickenDevs January 4, 2022 01:25
@Lulalaby Lulalaby merged commit 99e2312 into Pycord-Development:master Jan 4, 2022
@Dorukyum Dorukyum deleted the fix-groups branch January 4, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: high High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants