feat: Implement better get_or_fetch by Lumabots · Pull Request #2776 · Pycord-Development/pycord

Lumabots · 2025-05-03T20:58:09Z

Summary

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters). Implement better get_or_fetch #1856
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-05-03T20:58:58Z

feat from #1856

discord/utils.py

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-05-03T23:23:03Z

still not ready have some bug like : NameError: name 'VoiceChannel' is not defined
ig because of the type checking, i'll have to find a way to import it without circular import

Paillat-dev · 2025-05-03T23:24:50Z

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

Lumabots · 2025-05-03T23:35:10Z

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

Well ig the issue come from the definition for the typevar, so will that resolve it ?

… get_or_fetch shortcut Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-05-04T16:02:23Z

should be ready for review

Lumabots · 2025-05-04T16:03:07Z

just need to specify that this is breaking inside the changelog cos of modification of get_or_fetch and removal of get_or_fetch_user

Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

discord/utils.py

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

discord/utils.py

discord/guild.py

discord/client.py

discord/utils.py

Paillat-dev

Lgtm tested other than comments

CHANGELOG.md

discord/client.py

discord/utils.py

Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

…o get_or_fetch

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

discord/guild.py

discord/client.py

discord/guild.py

discord/client.py

Paillat-dev

Lgtm tested

Lumabots added 5 commits May 3, 2025 00:37

Update CHANGELOG.md

dce0206

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

add a get or fetch to guild

b2b8884

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Implement better get_or_fetch using typevar and object

8f9a257

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

shortcut for get or fetch

9f6219c

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update CHANGELOG.md

4af5149

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots requested a review from a team as a code owner May 3, 2025 20:58

pullapprove4 bot requested a review from VincentRPS May 3, 2025 20:58

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels May 3, 2025

style(pre-commit): auto fixes from pre-commit.com hooks

6f59fcd

Paillat-dev reviewed May 3, 2025

View reviewed changes

discord/utils.py Outdated Show resolved Hide resolved

Lumabots and others added 5 commits May 4, 2025 01:30

usage of subclass

c0689cc

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

b20822a

add get_emoji method

4a363f5

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

c3a7dd2

add get_or_fetch_emoji method

e614c47

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots and others added 8 commits May 4, 2025 18:22

shortcut getorfetch client + removal of get_or_fetch user in favor of…

0c0a042

… get_or_fetch shortcut Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

466e41b

Update utils.py

388a234

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update guild.py

9737f69

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update client.py

656de14

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

461eab7

Update utils.py

b6f8878

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

f2a7d72

Lumabots and others added 4 commits October 11, 2025 08:23

Update discord/utils.py

58b92f3

Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

fix: 🐛 Prevent InvalidArgument for AppEmoji in get_or_fetch method

6240173

fix: 🐛 Import AppEmoji in get_or_fetch to resolve potential issues

9fdcad4

style(pre-commit): auto fixes from pre-commit.com hooks

316e07d

Lumabots requested a review from Soheab October 11, 2025 08:22

pullapprove4 bot added the PA: All Contributors pending label Oct 11, 2025

Paillat-dev reviewed Oct 11, 2025

View reviewed changes

discord/utils.py Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Oct 11, 2025

Soheab previously approved these changes Oct 11, 2025

View reviewed changes

Lumabots requested review from Paillat-dev and Copilot October 14, 2025 08:38

pullapprove4 bot added the PA: Maintainers pending label Oct 14, 2025

Copilot AI reviewed Oct 14, 2025

View reviewed changes

discord/utils.py Show resolved Hide resolved

discord/guild.py Show resolved Hide resolved

discord/client.py Show resolved Hide resolved

discord/utils.py Show resolved Hide resolved

discord/utils.py Show resolved Hide resolved

Paillat-dev requested changes Oct 19, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

discord/client.py Show resolved Hide resolved

discord/utils.py Show resolved Hide resolved

discord/utils.py Outdated Show resolved Hide resolved

pullapprove4 bot removed the PA: Maintainers pending label Oct 19, 2025

Paillat-dev and others added 2 commits October 19, 2025 15:28

Merge branch 'master' into get_or_fetch

e068605

Update CHANGELOG.md

10b5bbd

Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots dismissed Soheab’s stale review via 10b5bbd October 19, 2025 15:42

Lumabots and others added 4 commits October 19, 2025 17:42

Update utils.py

3c89f07

Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

2b14ece

fix: 🐛 Import AppEmoji in _get_string_to_type_map for type mapping

82e11f3

Merge branch 'get_or_fetch' of https://github.com/Lumabots/pycord int…

c3173e9

…o get_or_fetch

Lumabots requested a review from Copilot October 19, 2025 17:30

style(pre-commit): auto fixes from pre-commit.com hooks

915e164

Copilot AI reviewed Oct 19, 2025

View reviewed changes

discord/guild.py Show resolved Hide resolved

discord/client.py Show resolved Hide resolved

discord/guild.py Show resolved Hide resolved

discord/client.py Show resolved Hide resolved

Lumabots requested a review from Paillat-dev October 20, 2025 09:22

Merge branch 'master' into get_or_fetch

228bb4a

Paillat-dev approved these changes Oct 20, 2025

View reviewed changes

Lulalaby approved these changes Oct 20, 2025

View reviewed changes

Uh oh!

Conversation

Lumabots commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

Lumabots commented May 3, 2025

Uh oh!

Uh oh!

Lumabots commented May 3, 2025

Uh oh!

Paillat-dev commented May 3, 2025

Uh oh!

Lumabots commented May 3, 2025

Uh oh!

Lumabots commented May 4, 2025

Uh oh!

Lumabots commented May 4, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Lumabots commented May 3, 2025 •

edited

Loading