fix: 🏷️ Fix types in Select.__init__#2746
Merged
Lulalaby merged 3 commits intoPycord-Development:masterfrom Mar 21, 2025
Merged
fix: 🏷️ Fix types in Select.__init__#2746Lulalaby merged 3 commits intoPycord-Development:masterfrom
Select.__init__#2746Lulalaby merged 3 commits intoPycord-Development:masterfrom
Conversation
plun1331
reviewed
Mar 21, 2025
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Paillat <jeremiecotti@ik.me>
Lulalaby
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without this change, instantiating any select menu could (depending on your type checker settings) trigger an error, because the default value of the parameters doesn't match the parameter's type.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.