feat: add Message._raw_data#2670
Conversation
This reverts commit a779c6f.
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Timo <35654063+tibue99@users.noreply.github.com>
JustaSqu1d
left a comment
There was a problem hiding this comment.
MessagePayload is not a documented class. Please add the class to documentation.
|
Or maybe document it as |
Head branch was pushed to by a user without write access
|
It's done this way for |
|
Do we really need to store the raw message data publicly? |
Are you suggesting something like |
|
I'm skeptical about the necessity of this attribute |
|
This attribute is useful for handling transcripts and other cases where messages need to be stored. It doesn't matter to me if it's public or private, but I strongly recommend adding it. Users should be able to use it freely if they need to. |
|
I see how having |
Signed-off-by: Timo <35654063+tibue99@users.noreply.github.com>
|
I can see value to adding it, but only as undocumented private field. |
|
In the For example: print(before._raw_data["content"])
print(after._raw_data["content"])Both lines output the original message content, not the updated one. However, if I manually fetch the message using This suggests the issue may be related to caching. Can you confirm if you’re seeing the same behavior on your end, and whether |
This is because The |
|
Please open a new issue if you're having problems. |
Sure |
Summary
This PR adds
Message.data, which is useful for handling message data or creating transcripts.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.