fix: 🐛 Fix Interaction.channel incorrectly set#2658
Merged
Lulalaby merged 15 commits intoPycord-Development:masterfrom Jan 10, 2025
Merged
fix: 🐛 Fix Interaction.channel incorrectly set#2658Lulalaby merged 15 commits intoPycord-Development:masterfrom
Interaction.channel incorrectly set#2658Lulalaby merged 15 commits intoPycord-Development:masterfrom
Conversation
d9af48f to
0fcf795
Compare
8683daa to
96a3141
Compare
Interaction.channel incorrectly setInteraction.channel incorrectly set
Member
|
Removing |
Member
Author
|
Ok |
JustaSqu1d
requested changes
Dec 12, 2024
Member
JustaSqu1d
left a comment
There was a problem hiding this comment.
please fix changelog entry
Signed-off-by: Paillat <me@paillat.dev>
JustaSqu1d
requested changes
Dec 17, 2024
Lulalaby
previously approved these changes
Dec 23, 2024
Dorukyum
reviewed
Dec 26, 2024
Dorukyum
reviewed
Dec 27, 2024
Signed-off-by: Paillat <me@paillat.dev>
Dorukyum
previously approved these changes
Dec 28, 2024
3 tasks
Dorukyum
approved these changes
Jan 10, 2025
Lulalaby
approved these changes
Jan 10, 2025
Member
|
Should've added a changelog entry under "Deprecated". |
Member
Author
|
I'll open another pr |
Member
|
No need, I'll push it while updating the changelog at the time of release. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InteractionPayload["channel"]is partial, thus, when creating a GuildChannel object from it, some attributes were missing/incorrectly set. With this pr,InteractionPayload["channel"]is used only in the following cases:In all other cases, it uses the full channel object from the cache.
Information
fixes:
permissions_forreturning wrong permissions #2281examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.