Skip to content

feat: ✨ Add MediaChannel and fix ForumChannel flags#2641

Merged
Lulalaby merged 16 commits intoPycord-Development:masterfrom
Paillat-dev:feat-media-channels
Jan 28, 2025
Merged

feat: ✨ Add MediaChannel and fix ForumChannel flags#2641
Lulalaby merged 16 commits intoPycord-Development:masterfrom
Paillat-dev:feat-media-channels

Conversation

@Paillat-dev
Copy link
Member

@Paillat-dev Paillat-dev commented Nov 8, 2024 •
edited
Loading

Summary

Fix #2637
Fix #2640

Information

  • This PR fixes two issues.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner November 8, 2024 21:37
@pullapprove4 pullapprove4 bot requested a review from VincentRPS November 8, 2024 21:37
@pullapprove4 pullapprove4 bot requested a review from Dorukyum November 8, 2024 21:37
@Paillat-dev Paillat-dev changed the title ✨ MediaChannel feat: ✨ Add MediaChannel and fix ForumChannel flags Nov 8, 2024
@Lulalaby Lulalaby requested review from Lulalaby and removed request for Dorukyum and VincentRPS November 8, 2024 21:56
Lulalaby
Lulalaby reviewed Nov 9, 2024
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure but afaik I the channel class you also have a model for the base type which has type: literal channel type blah. Is that perhaps missing?

@Paillat-dev
Copy link
Member Author

Paillat-dev commented Nov 9, 2024

I'm not entirely sure but afaik I the channel class you also have a model for the base type which has type: literal channel type blah. Is that perhaps missing?

type is present as a property in some channel classes but not all, for example it is not in TextChannel (which I found weird tbh) but is in others. I added it to ForumChannel and MediaChannel, even tough it works without because it is already implemented in _TextChannel as follows:

    @property
    def type(self) -> ChannelType:
        """The channel's Discord type."""
        return try_enum(ChannelType, self._type)

@Dorukyum
Copy link
Member

Dorukyum commented Nov 9, 2024

It's redundant if the classes inherit from _TextChannel.

@Paillat-dev
Copy link
Member Author

Paillat-dev commented Nov 9, 2024

Undid it then

Lulalaby
Lulalaby previously approved these changes Nov 11, 2024
View reviewed changes
Dorukyum
Dorukyum previously requested changes Nov 11, 2024
View reviewed changes
Dorukyum and others added 2 commits November 16, 2024 13:51
@Dorukyum
refactor: switch to try-except
99596cc 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Paillat-dev
🩹 Allow MediaChannel as slash option.
0b3f756
@Paillat-dev Paillat-dev requested a review from Lulalaby January 8, 2025 12:15
@Paillat-dev
Merge branch 'master' into feat-media-channels
7f6b0c8 
Signed-off-by: Paillat <me@paillat.dev>
@Paillat-dev
Copy link
Member Author

Paillat-dev commented Jan 9, 2025

Can someone pls retry the readthedocs action ?

@Lulalaby
Copy link
Member

Lulalaby commented Jan 9, 2025

no :p

plun1331
plun1331 requested changes Jan 21, 2025
View reviewed changes
@Paillat-dev Paillat-dev requested a review from plun1331 January 23, 2025 07:31
plun1331
plun1331 previously approved these changes Jan 28, 2025
View reviewed changes
plun1331
plun1331 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'scuse me, i approved this

Lulalaby
Lulalaby approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well you gotta wait for pre-commit to be done @plun1331

@Lulalaby Lulalaby merged commit 8c3a621 into Pycord-Development:master Jan 28, 2025
23 checks passed
@Paillat-dev Paillat-dev deleted the feat-media-channels branch January 28, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing channel types to channel.py Support GUILD_MEDIA channel type

5 participants

@Paillat-dev @Dorukyum @Lulalaby @plun1331 @JustaSqu1d