feat: Voice Message Sending#2579
Merged
Lulalaby merged 24 commits intoPycord-Development:masterfrom Dec 28, 2024
Merged
Conversation
Member
|
Potentially related commit: discord/discord-api-docs@e6cf4a9 |
|
DAPI #7158 has been closed and I've been using this PR in a project for a couple weeks now without issues. Is it ready to merge? |
Member
Author
|
As far as I know this has not been officially added to the API as it is not strictly documented. Also last time I tested it I was having issues getting the waveforms to display on interaction responses. |
…into voice_messages
Signed-off-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Dorukyum
reviewed
Dec 27, 2024
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Dorukyum
reviewed
Dec 27, 2024
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Signed-off-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Dorukyum
approved these changes
Dec 28, 2024
Lulalaby
approved these changes
Dec 28, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for sending voice messages. This includes the
waveformandduration_secparameters that can be used in the new VoiceMessage subclass.Solves #2575
Resolved, was a py-cord bug:
This will be a draft until I have confirmed the behavior ofwaveforms andduration_secin interaction responses.As of now I believe there is a discord bug that causes them to be ignored.
Resolved:
Also Pending: DAPI #7158Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.