Skip to content

feat: add banner to ClientUser.edit#2396

Merged
Lulalaby merged 9 commits intoPycord-Development:masterfrom
Braandn:master
Mar 17, 2024
Merged

feat: add banner to ClientUser.edit#2396
Lulalaby merged 9 commits intoPycord-Development:masterfrom
Braandn:master

Conversation

@Braandn
Copy link
Contributor

@Braandn Braandn commented Mar 15, 2024 •
edited
Loading

Added "banner" to the edit function.

Till now the official discord docs are not updated, but its is working.

ref: discord/discord-api-docs#6710

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Braandn
Ability to change/set the banner of the bot.
8bdcaf7 
Added "banner" to the edit function.

Till now the official discord docs are not updated, but the code is working.

ref: discord/discord-api-docs#6710

Signed-off-by: Brandon <Brandon.k@live.de>
@Braandn Braandn requested a review from a team as a code owner March 15, 2024 21:45
@pullapprove4 pullapprove4 bot requested a review from VincentRPS March 15, 2024 21:45
@JustaSqu1d JustaSqu1d added the hold: changelog This pull request is missing a changelog entry label Mar 15, 2024
plun1331
plun1331 requested changes Mar 16, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

@plun1331 plun1331 changed the title Ability to change/set the banner of the bot. feat: add banner to ClientUser.edit Mar 16, 2024
Braandn and others added 3 commits March 16, 2024 04:55
@Braandn @plun1331
user.py aktualisieren
214a275 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Brandon <Brandon.k@live.de>
@Braandn @plun1331
user.py aktualisieren
1b0bf7b 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Brandon <Brandon.k@live.de>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
bd943d1
plun1331
plun1331 reviewed Mar 16, 2024
View reviewed changes
@plun1331
Update discord/user.py
3c819a3 
Signed-off-by: plun1331 <plun1331@gmail.com>
Lulalaby
Lulalaby requested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

@plun1331 plun1331 enabled auto-merge (squash) March 17, 2024 07:12
@plun1331 plun1331 requested a review from Lulalaby March 17, 2024 07:13
@Lulalaby Lulalaby disabled auto-merge March 17, 2024 07:52
@Lulalaby Lulalaby enabled auto-merge (squash) March 17, 2024 07:53
@Lulalaby Lulalaby merged commit 530f3d4 into Pycord-Development:master Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

Assignees

No one assigned

Labels

hold: changelog This pull request is missing a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Braandn @Lulalaby @plun1331 @JustaSqu1d