fix: Proper type-hinting & docstring of Member.move_to and Member.edit#2386
Merged
Lulalaby merged 9 commits intoPycord-Development:masterfrom Mar 8, 2024
Merged
fix: Proper type-hinting & docstring of Member.move_to and Member.edit#2386Lulalaby merged 9 commits intoPycord-Development:masterfrom
Member.move_to and Member.edit#2386Lulalaby merged 9 commits intoPycord-Development:masterfrom
Conversation
Lulalaby
reviewed
Mar 8, 2024
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Lulalaby
previously approved these changes
Mar 8, 2024
Lulalaby
previously approved these changes
Mar 8, 2024
plun1331
previously requested changes
Mar 8, 2024
Signed-off-by: plun1331 <plun1331@gmail.com>
plun1331
reviewed
Mar 8, 2024
auto-merge was automatically disabled
March 8, 2024 19:24
Head branch was pushed to by a user without write access
Signed-off-by: YoggieS <61660055+yoggys@users.noreply.github.com>
Contributor
Author
|
@plun1331 I've also updated |
Member.move_toMember.move_to and Member.edit
Lulalaby
previously approved these changes
Mar 8, 2024
auto-merge was automatically disabled
March 8, 2024 20:44
Head branch was pushed to by a user without write access
Contributor
Author
|
that should be all related to |
Lulalaby
approved these changes
Mar 8, 2024
JustaSqu1d
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed type-hinting and docstring for
Member.move_toas channel is excepted to bechannel: Optional[:class:VoiceChannel]andMember.edit.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.