feat(ext.bridge): add bridge.Context as a Union class#2106
Merged
Lulalaby merged 11 commits intoPycord-Development:masterfrom Jun 11, 2023
Merged
feat(ext.bridge): add bridge.Context as a Union class#2106Lulalaby merged 11 commits intoPycord-Development:masterfrom
bridge.Context as a Union class#2106Lulalaby merged 11 commits intoPycord-Development:masterfrom
Conversation
Lulalaby
previously approved these changes
Jun 9, 2023
plun1331
reviewed
Jun 9, 2023
Middledot
approved these changes
Jun 11, 2023
Lulalaby
approved these changes
Jun 11, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shortcut Union class for
BridgeExtContext, andBridgeApplicationContext.Since
bridge.BridgeContextis an ABC, using that as a typehint doesn't display the attributes and methods available.Current Workaround
Using the long form everywhere
Desired Solution
Using the Union class
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.