Skip to content

feat: Add icon and unicode_emoji to Guild.create_role#2086

Merged
Lulalaby merged 3 commits intoPycord-Development:masterfrom
NeloBlivion:role_icon
May 23, 2023
Merged

feat: Add icon and unicode_emoji to Guild.create_role#2086
Lulalaby merged 3 commits intoPycord-Development:masterfrom
NeloBlivion:role_icon

Conversation

@NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented May 23, 2023

Summary

The icon and unicode_emoji args have been available in Role.edit from the start, but were never added to Guild.create_role.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner May 23, 2023 03:54
@JustaSqu1d JustaSqu1d added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature python API reflection Discord API isn't correctly reflected labels May 23, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) May 23, 2023 03:56
@Lulalaby Lulalaby merged commit 7bbb42a into Pycord-Development:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API reflection Discord API isn't correctly reflected feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants