fix: Make AuditLogEntry user/user_id optional#2079
Merged
Lulalaby merged 2 commits intoPycord-Development:masterfrom May 19, 2023
Merged
fix: Make AuditLogEntry user/user_id optional#2079Lulalaby merged 2 commits intoPycord-Development:masterfrom
Lulalaby merged 2 commits intoPycord-Development:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2079 +/- ##
==========================================
- Coverage 33.16% 33.16% -0.01%
==========================================
Files 97 97
Lines 19115 19117 +2
==========================================
Hits 6340 6340
- Misses 12775 12777 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Lulalaby
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
So apparently it's possible to recieve a user_id of
Nonefor audit log entries...Thus it's been made optional.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.