Skip to content

fix: channel id might be null#2078

Merged
Lulalaby merged 10 commits intomasterfrom
fix/webhooks_update
May 23, 2023
Merged

fix: channel id might be null#2078
Lulalaby merged 10 commits intomasterfrom
fix/webhooks_update

Conversation

@Lulalaby
Copy link
Member

No description provided.

@Lulalaby
Copy link
Member Author

Reason for this fix: discord just send a gateway payload where the channel id was null and it yeeted a fucking cluster

@Lulalaby Lulalaby self-assigned this May 18, 2023
@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority labels May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #2078 (2f13b00) into master (ad7056d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
- Coverage   33.14%   33.14%   -0.01%     
==========================================
  Files          97       97              
  Lines       19126    19129       +3     
==========================================
  Hits         6340     6340              
- Misses      12786    12789       +3     
Flag Coverage Δ
macos-latest-3.10 33.12% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.12% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.13% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.13% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.12% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.12% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.13% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.13% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.12% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.12% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.13% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/state.py 14.66% <0.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7056d...2f13b00. Read the comment docs.

Copy link
Contributor

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@Lulalaby Lulalaby requested a review from BobDotCom May 19, 2023 03:38
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
@Lulalaby Lulalaby requested a review from BobDotCom May 19, 2023 04:18
Lulalaby and others added 2 commits May 19, 2023 06:18
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
Dorukyum previously approved these changes May 19, 2023
Signed-off-by: Lala Sabathil <lala@pycord.dev>
@Lulalaby Lulalaby requested a review from Dorukyum May 20, 2023 03:35
@Lulalaby Lulalaby enabled auto-merge (squash) May 20, 2023 03:35
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby disabled auto-merge May 23, 2023 04:17
@Lulalaby Lulalaby enabled auto-merge (squash) May 23, 2023 04:17
@Lulalaby Lulalaby merged commit 8950c2e into master May 23, 2023
@Lulalaby Lulalaby deleted the fix/webhooks_update branch June 26, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: high High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants