Skip to content

fix: Improve Automod compatibility with Audit Logs + minor fixes#2030

Merged
Lulalaby merged 10 commits intoPycord-Development:masterfrom
NeloBlivion:audit_chores
Apr 26, 2023
Merged

fix: Improve Automod compatibility with Audit Logs + minor fixes#2030
Lulalaby merged 10 commits intoPycord-Development:masterfrom
NeloBlivion:audit_chores

Conversation

@NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Apr 25, 2023 •
edited by plun1331
Loading

Summary

  • Adds missing audit log event enums related to automod, alongside their relevant docs
  • Adds transformer support for several AutoModRule attributes
  • Adds missing audit log attributes related to automod
  • Fix repr typo for AutoModTriggerMetadata

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner April 25, 2023 06:04
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #2030 (d980cdf) into master (2544830) will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
- Coverage   33.28%   33.26%   -0.02%     
==========================================
  Files          97       97              
  Lines       18987    19021      +34     
==========================================
+ Hits         6320     6328       +8     
- Misses      12667    12693      +26
Flag Coverage Δ
macos-latest-3.10 33.25% <22.22%> (-0.02%) ⬇️
macos-latest-3.11 33.25% <22.22%> (-0.02%) ⬇️
macos-latest-3.8 33.26% <22.22%> (-0.02%) ⬇️
macos-latest-3.9 33.26% <22.22%> (-0.02%) ⬇️
ubuntu-latest-3.10 33.25% <22.22%> (-0.02%) ⬇️
ubuntu-latest-3.11 33.25% <22.22%> (-0.02%) ⬇️
ubuntu-latest-3.8 33.26% <22.22%> (-0.02%) ⬇️
ubuntu-latest-3.9 33.26% <22.22%> (-0.02%) ⬇️
windows-latest-3.10 33.25% <22.22%> (-0.02%) ⬇️
windows-latest-3.11 33.25% <22.22%> (-0.02%) ⬇️
windows-latest-3.8 33.26% <22.22%> (-0.02%) ⬇️
windows-latest-3.9 33.26% <22.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/automod.py 27.97% <0.00%> (ø)
discord/audit_logs.py 27.53% <18.75%> (-0.99%) ⬇️
discord/enums.py 80.03% <66.66%> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2544830...d980cdf. Read the comment docs.

plun1331
plun1331 previously requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

@plun1331 plun1331 added status: awaiting review Awaiting review from a maintainer feature Implements a feature hold: changelog This pull request is missing a changelog entry labels Apr 25, 2023
@Lulalaby Lulalaby removed the hold: changelog This pull request is missing a changelog entry label Apr 25, 2023
@Lulalaby
Merge branch 'master' into audit_chores
a2e0e10 
Signed-off-by: Lala Sabathil <lala@pycord.dev>
@Lulalaby Lulalaby enabled auto-merge (squash) April 25, 2023 17:36
Lulalaby
Lulalaby reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but someone please test and approve

@Lulalaby Lulalaby merged commit 05b5ae3 into Pycord-Development:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby left review comments

@BobDotCom BobDotCom BobDotCom approved these changes

@plun1331 plun1331 plun1331 left review comments

@WhoIsConch WhoIsConch Awaiting requested review from WhoIsConch

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266

Assignees

No one assigned

Labels

feature Implements a feature status: awaiting review Awaiting review from a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NeloBlivion @Lulalaby @plun1331 @BobDotCom