Skip to content

feat(ApplicationFlags): add application_auto_moderation_rule_create_badge#1992

Merged
Lulalaby merged 8 commits intoPycord-Development:masterfrom
JustaSqu1d:patch-6
Mar 29, 2023
Merged

feat(ApplicationFlags): add application_auto_moderation_rule_create_badge#1992
Lulalaby merged 8 commits intoPycord-Development:masterfrom
JustaSqu1d:patch-6

Conversation

@JustaSqu1d
Copy link
Member

@JustaSqu1d JustaSqu1d commented Mar 29, 2023

Summary

discord/discord-api-docs#6021

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@JustaSqu1d JustaSqu1d requested a review from a team as a code owner March 29, 2023 04:47
Lulalaby
Lulalaby previously approved these changes Mar 29, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) March 29, 2023 04:49
@Lulalaby Lulalaby requested a review from ChickenDevs March 29, 2023 04:49
@JustaSqu1d JustaSqu1d added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature python labels Mar 29, 2023
ChickenDevs
ChickenDevs previously approved these changes Mar 29, 2023
@Lulalaby Lulalaby disabled auto-merge March 29, 2023 04:52
@JustaSqu1d JustaSqu1d dismissed stale reviews from ChickenDevs and Lulalaby via 6318625 March 29, 2023 04:54
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>
@Lulalaby
Copy link
Member

mhh do we need a version added 🤣

@plun1331
Copy link
Member

and now we wait for tests to run again

@plun1331
Copy link
Member

mhh do we need a version added 🤣

maybe

@Lulalaby Lulalaby added this to the v2.5 milestone Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1992 (1f1372f) into master (2e9ab61) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
+ Coverage   33.33%   33.34%   +0.01%     
==========================================
  Files          97       97              
  Lines       18891    18894       +3     
==========================================
+ Hits         6297     6300       +3     
  Misses      12594    12594              
Flag Coverage Δ
macos-latest-3.10 33.32% <100.00%> (+0.01%) ⬆️
macos-latest-3.11 33.32% <100.00%> (+0.01%) ⬆️
macos-latest-3.8 33.34% <100.00%> (+0.01%) ⬆️
macos-latest-3.9 33.34% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.10 33.32% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.11 33.32% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.8 33.34% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.9 33.34% <100.00%> (+0.01%) ⬆️
windows-latest-3.10 33.32% <100.00%> (+0.01%) ⬆️
windows-latest-3.11 33.32% <100.00%> (+0.01%) ⬆️
windows-latest-3.8 33.34% <100.00%> (+0.01%) ⬆️
windows-latest-3.9 33.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/flags.py 76.44% <100.00%> (+0.17%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9ab61...1f1372f. Read the comment docs.

Signed-off-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby
Copy link
Member

your own approval won't work

@Lulalaby Lulalaby enabled auto-merge (squash) March 29, 2023 04:58
@plun1331
Copy link
Member

your own approval won't work

god damn it

@JustaSqu1d JustaSqu1d requested a review from ChickenDevs March 29, 2023 04:58
@Lulalaby Lulalaby merged commit 93c28aa into Pycord-Development:master Mar 29, 2023
@JustaSqu1d JustaSqu1d deleted the patch-6 branch March 29, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants