feat: add current_page parameter to paginator.update()#1983
Merged
Lulalaby merged 2 commits intoPycord-Development:masterfrom Mar 24, 2023
Merged
feat: add current_page parameter to paginator.update()#1983Lulalaby merged 2 commits intoPycord-Development:masterfrom
Lulalaby merged 2 commits intoPycord-Development:masterfrom
Conversation
Signed-off-by: DefiDebauchery <75273961+DefiDebauchery@users.noreply.github.com>
for more information, see https://pre-commit.ci
Member
|
Title :^) |
Lulalaby
approved these changes
Mar 24, 2023
ChickenDevs
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When updating the Paginator, the view always resets to page 0. This isn't always desirable, and enabling the optional argument simplifies logic without getting in the way of typical operation.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.