Skip to content

fix(misc): RawAuditLogEntryEvent fixes#1937

Merged
Lulalaby merged 2 commits intoPycord-Development:masterfrom
NeloBlivion:audit_event
Feb 22, 2023
Merged

fix(misc): RawAuditLogEntryEvent fixes#1937
Lulalaby merged 2 commits intoPycord-Development:masterfrom
NeloBlivion:audit_event

Conversation

@NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Feb 22, 2023

  • Added guild_id to slots. It was already an attribute, but not useable.
  • Made target_id optional

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Was already an attribute, but forgot in slots and docs
@NeloBlivion NeloBlivion requested a review from a team as a code owner February 22, 2023 18:31
@JustaSqu1d JustaSqu1d added the API reflection Discord API isn't correctly reflected label Feb 22, 2023
@NeloBlivion NeloBlivion changed the title fix: include guild_id in RawAuditLogEntryEvent fix: misc. RawAuditLogEntryEvent fixes Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1937 (adffed0) into master (8a91137) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1937      +/-   ##
==========================================
- Coverage   33.37%   33.37%   -0.01%     
==========================================
  Files          97       97              
  Lines       18845    18847       +2     
==========================================
  Hits         6290     6290              
- Misses      12555    12557       +2     
Flag Coverage Δ
macos-latest-3.10 33.35% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.35% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.37% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.37% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.35% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.35% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.37% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.37% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.35% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.35% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.37% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/raw_models.py 29.47% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a91137...adffed0. Read the comment docs.

@Lulalaby Lulalaby enabled auto-merge (squash) February 22, 2023 23:08
@Lulalaby Lulalaby changed the title fix: misc. RawAuditLogEntryEvent fixes fix(misc): RawAuditLogEntryEvent fixes Feb 22, 2023
@Lulalaby Lulalaby disabled auto-merge February 22, 2023 23:08
@Lulalaby Lulalaby enabled auto-merge (squash) February 22, 2023 23:08
@Lulalaby Lulalaby merged commit 8c95c94 into Pycord-Development:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API reflection Discord API isn't correctly reflected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants