feat: Support for text in stage#1936
Conversation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1936 +/- ##
==========================================
- Coverage 33.33% 33.32% -0.02%
==========================================
Files 97 97
Lines 18867 18901 +34
==========================================
+ Hits 6290 6298 +8
- Misses 12577 12603 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What if we created a new class for thread related stuff, so it looks something like this: Could you make an issue for this? I think it's a good idea, but I also agree that it's out of the scope of this PR. |
BobDotCom
left a comment
There was a problem hiding this comment.
Please add a changelog entry
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Head branch was pushed to by a user without write access
60ff3f1
Summary
Adds support for Text channels in Stage as per discord/discord-api-docs#5928
Closes #1934
abc.Messageablensfwslot toVocalGuildChannelThis PR is more or less a mirror of #1231 for
StageChannel, however the implementation is somewhat unsatisfying; I think It'd be more ideal forVoiceChannelandStageChannelto inherit from_TextChanneland then move the thread-related functions & attributes from_TextChanneltoTextChannelandForumChannel, but to keep in scope I went with the basic route of just mimicking the previous changes withStageChannel. If the suggested alternative is considered a better solution then I'll go ahead with that refactor instead.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.