feat!: add missing embedded activities by JustaSqu1d · Pull Request #1859 · Pycord-Development/pycord

JustaSqu1d · 2023-01-05T23:50:06Z

Summary

Adds missing activities. Source of information: https://gist.github.com/GeneralSadaf/42d91a2b6a93a7db7a39208f2d8b53ad

This PR also renames activities that have changed names.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.

for more information, see https://pre-commit.ci

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>

for more information, see https://pre-commit.ci

…atch-1

CHANGELOG.md

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>

BobDotCom · 2023-01-06T21:52:31Z

Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed?

for more information, see https://pre-commit.ci

JustaSqu1d · 2023-01-06T21:53:46Z

Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed?

What about also adding something under the "Changed" section to note the activities' names that were changed?

Should I remove the changelog entry in "Added" and "Removed" and put it under "Changed"?

JustaSqu1d · 2023-01-07T17:36:09Z

@Lulalaby No, this is a breaking change. It changes the names of ocho to blazing_8s, chest_in_the_park to chess_in_the_park, etc.

BobDotCom · 2023-01-09T17:10:43Z

Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed?

What about also adding something under the "Changed" section to note the activities' names that were changed?

Should I remove the changelog entry in "Added" and "Removed" and put it under "Changed"?

If there were only changes and additions, that would be best

codecov · 2023-01-09T18:31:54Z

Codecov Report

Merging #1859 (b962416) into master (e165ebc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   33.21%   33.27%   +0.05%     
==========================================
  Files          96       96              
  Lines       18680    18695      +15     
==========================================
+ Hits         6205     6220      +15     
  Misses      12475    12475

Flag	Coverage Δ
macos-latest-3.10	`33.25% <100.00%> (+0.05%)`	⬆️
macos-latest-3.11	`33.25% <100.00%> (+0.05%)`	⬆️
macos-latest-3.8	`33.26% <100.00%> (+0.05%)`	⬆️
macos-latest-3.9	`33.26% <100.00%> (+0.05%)`	⬆️
ubuntu-latest-3.10	`33.25% <100.00%> (+0.05%)`	⬆️
ubuntu-latest-3.11	`33.25% <100.00%> (+0.05%)`	⬆️
ubuntu-latest-3.8	`33.26% <100.00%> (+0.05%)`	⬆️
ubuntu-latest-3.9	`33.26% <100.00%> (+0.05%)`	⬆️
windows-latest-3.10	`33.25% <100.00%> (+0.05%)`	⬆️
windows-latest-3.11	`33.25% <100.00%> (+0.05%)`	⬆️
windows-latest-3.8	`33.26% <100.00%> (+0.05%)`	⬆️
windows-latest-3.9	`33.26% <100.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
discord/enums.py	`79.61% <100.00%> (+0.55%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e165ebc...b962416. Read the comment docs.

Adding "changed" and "removed" change-log categories entries

CHANGELOG.md

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>

Lulalaby

LGTM but as note: dev activities are restricted server side, so no use mostly

JustaSqu1d and others added 14 commits January 3, 2023 16:37

feat: add role-subscription purchase enum

40ced00

[pre-commit.ci] auto fixes from pre-commit.com hooks

2e1397c

for more information, see https://pre-commit.ci

feat: add new message types

47c55b0

chore: add changelog entry for new message types

86838e2

[pre-commit.ci] auto fixes from pre-commit.com hooks

f4bef7c

for more information, see https://pre-commit.ci

Merge branch 'master' into patch-1

8ca733f

Update docs/api/enums.rst

32872a2

Update CHANGELOG.md

f7f322c

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>

Update docs/api/enums.rst

dbe5da3

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>

Merge branch 'master' into patch-1

6235720

Merge branch 'master' into patch-1

20a0042

Merge branch 'master' into patch-1

771d751

feat: add missing embedded activities

2211efe

docs: add missing embedded activities

dca9c98

JustaSqu1d requested a review from a team as a code owner January 5, 2023 23:50

JustaSqu1d and others added 2 commits January 5, 2023 15:50

Merge branch 'master' into patch-1

580d973

[pre-commit.ci] auto fixes from pre-commit.com hooks

874c307

for more information, see https://pre-commit.ci

JustaSqu1d changed the title ~~feat: add missing activities~~ feat!: add missing activities Jan 5, 2023

JustaSqu1d marked this pull request as draft January 5, 2023 23:52

JustaSqu1d added 2 commits January 5, 2023 15:55

chore: add changelog entry

c647526

Merge branch 'patch-1' of https://github.com/JustaSqu1d/pycord into p…

6e26a23

…atch-1

JustaSqu1d marked this pull request as ready for review January 5, 2023 23:58

JustaSqu1d changed the title ~~feat!: add missing activities~~ feat!: add missing embedded activities Jan 5, 2023

BobDotCom reviewed Jan 6, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

JustaSqu1d and others added 2 commits January 6, 2023 13:50

Update CHANGELOG.md

263f5f4

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>

Merge branch 'master' into patch-1

23e217f

[pre-commit.ci] auto fixes from pre-commit.com hooks

016c664

for more information, see https://pre-commit.ci

Lulalaby changed the title ~~feat!: add missing embedded activities~~ feat: add missing embedded activities Jan 7, 2023

JustaSqu1d changed the title ~~feat: add missing embedded activities~~ feat!: add missing embedded activities Jan 7, 2023

Merge branch 'master' into patch-1

5dd5212

Nzii3 previously approved these changes Jan 9, 2023

View reviewed changes

BobDotCom and others added 2 commits January 9, 2023 12:32

Merge branch 'master' into patch-1

e44f257

fix: change-log entries

6d89391

Adding "changed" and "removed" change-log categories entries

JustaSqu1d dismissed Nzii3’s stale review via 6d89391 January 9, 2023 18:51

JustaSqu1d requested review from BobDotCom and Nzii3 January 9, 2023 18:52

JustaSqu1d added status: awaiting review Awaiting review from a maintainer priority: medium Medium Priority feature Implements a feature API reflection Discord API isn't correctly reflected labels Jan 9, 2023

BobDotCom reviewed Jan 10, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

ec9e159

Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>

BobDotCom enabled auto-merge (squash) January 10, 2023 15:57

BobDotCom approved these changes Jan 10, 2023

View reviewed changes

Merge branch 'master' into patch-1

b962416

Nzii3 approved these changes Jan 10, 2023

View reviewed changes

Lulalaby approved these changes Jan 10, 2023

View reviewed changes

BobDotCom merged commit ce16709 into Pycord-Development:master Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat!: add missing embedded activities#1859

feat!: add missing embedded activities#1859
BobDotCom merged 26 commits intoPycord-Development:masterfrom
JustaSqu1d:patch-1

JustaSqu1d commented Jan 5, 2023 •

edited

Loading

Uh oh!

Uh oh!

BobDotCom commented Jan 6, 2023

Uh oh!

JustaSqu1d commented Jan 6, 2023 •

edited

Loading

Uh oh!

JustaSqu1d commented Jan 7, 2023

Uh oh!

BobDotCom commented Jan 9, 2023

Uh oh!

codecov bot commented Jan 9, 2023 •

edited

Loading

Uh oh!

Uh oh!

Lulalaby left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

JustaSqu1d commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

Uh oh!

BobDotCom commented Jan 6, 2023

Uh oh!

JustaSqu1d commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JustaSqu1d commented Jan 7, 2023

Uh oh!

BobDotCom commented Jan 9, 2023

Uh oh!

codecov bot commented Jan 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Lulalaby left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JustaSqu1d commented Jan 5, 2023 •

edited

Loading

JustaSqu1d commented Jan 6, 2023 •

edited

Loading

codecov bot commented Jan 9, 2023 •

edited

Loading