Fix AttributeError: 'NoneType' object has no attribute 'finalize' on TPU by chizuchizu · Pull Request #6221 · Lightning-AI/pytorch-lightning

chizuchizu · 2021-02-26T12:46:13Z

Fix AttributeError: 'NoneType' object has no attribute 'finalize'

What does this PR do?

Issue

import pytorch_lightning as pl

my_model = MyLightningModule()
trainer = pl.Trainer(tpu_cores=8, logger=None)
trainer.fit(my_model)

If you run the code written above, you will get the error below.

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/plugins/training_type/tpu_spawn.py in _close_logger(self, trainer)
    236     def _close_logger(self, trainer) -> None:
    237         if hasattr(trainer, "logger"):
--> 238             trainer.logger.finalize("success")
    239 
    240     @property

AttributeError: 'NoneType' object has no attribute 'finalize'

This bug is caused by not being able to handle the case where the attribute logger exists and logger.finalize does not.

CHANGE

pytorch_lightning/plugins/training_type/tpu_spawn.py the 249th line

BEFORE

def _close_logger(self, trainer) -> None:
    if hasattr(trainer, "logger"):
        trainer.logger.finalize("success")

AFTER

def _close_logger(self, trainer) -> None:
    if hasattr(trainer, "logger.finalize"):
        trainer.logger.finalize("success")

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

This is the first pull request to OSS in my life. So, of course, yes:)

Fix AttributeError: 'NoneType' object has no attribute 'finalize'

codecov · 2021-02-26T12:48:08Z

Codecov Report

Merging #6221 (8af16be) into master (ff16104) will decrease coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6221    +/-   ##
=======================================
- Coverage      94%     90%    -3%     
=======================================
  Files         161     161            
  Lines       11486   11376   -110     
=======================================
- Hits        10745   10275   -470     
- Misses        741    1101   +360

Borda

mind add chlog :]
also pls keep the bullet-list form template

chizuchizu · 2021-02-26T13:11:47Z

@Borda

Thanks for the review.

I've added bulle-list and CHANGELOG.md.

CHANGELOG.md

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

CHANGELOG.md

pytorch_lightning/plugins/training_type/tpu_spawn.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

tchaton

Thanks for resolving my bug :)

…TPU (#6221) * Fix bug Fix AttributeError: 'NoneType' object has no attribute 'finalize' * Update CHANGELOG.md * deleted a period * Update CHANGELOG.md Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> * Update CHANGELOG.md * Update pytorch_lightning/plugins/training_type/tpu_spawn.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Fix bug

66dae87

Fix AttributeError: 'NoneType' object has no attribute 'finalize'

chizuchizu requested review from SeanNaren, awaelchli, justusschock and tchaton as code owners February 26, 2021 12:46

Borda added the bug Something isn't working label Feb 26, 2021

Borda added this to the 1.2.x milestone Feb 26, 2021

Borda approved these changes Feb 26, 2021

View reviewed changes

Borda added the ready to be merged PRs ready to be merged label Feb 26, 2021

akihironitta approved these changes Feb 26, 2021

View reviewed changes

Update CHANGELOG.md

db159b3

chizuchizu requested review from carmocca and williamFalcon as code owners February 26, 2021 13:10

deleted a period

3507ed0

akihironitta approved these changes Feb 26, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

2a9751c

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

SkafteNicki approved these changes Feb 26, 2021

View reviewed changes

carmocca reviewed Feb 26, 2021

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Update CHANGELOG.md

f23a52a

carmocca approved these changes Feb 26, 2021

View reviewed changes

rohitgr7 reviewed Feb 26, 2021

View reviewed changes

pytorch_lightning/plugins/training_type/tpu_spawn.py Outdated Show resolved Hide resolved

mergify bot added the has conflicts label Feb 27, 2021

chizuchizu and others added 2 commits February 27, 2021 15:39

Update pytorch_lightning/plugins/training_type/tpu_spawn.py

556fc85

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Merge branch 'master' into master

3ff0ce6

mergify bot removed the has conflicts label Feb 27, 2021

rohitgr7 enabled auto-merge (squash) February 27, 2021 09:19

mergify bot added the has conflicts label Mar 1, 2021

Merge branch 'master' into master

1ca2616

mergify bot added has conflicts and removed has conflicts labels Mar 2, 2021

Merge branch 'master' into master

582107f

tchaton approved these changes Mar 3, 2021

View reviewed changes

mergify bot removed the has conflicts label Mar 3, 2021

Borda added the accelerator: tpu Tensor Processing Unit label Mar 4, 2021

mergify bot added has conflicts and removed has conflicts labels Mar 5, 2021

Merge branch 'master' into ch_master

e57477a

s-rog approved these changes Mar 8, 2021

View reviewed changes

rohitgr7 merged commit a6c98c4 into Lightning-AI:master Mar 8, 2021

tchaton mentioned this pull request Mar 8, 2021

1.2.x cherries 🍒 #6083

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix AttributeError: 'NoneType' object has no attribute 'finalize' on TPU#6221

Fix AttributeError: 'NoneType' object has no attribute 'finalize' on TPU#6221
rohitgr7 merged 10 commits intoLightning-AI:masterfrom
chizuchizu:master

chizuchizu commented Feb 26, 2021 •

edited

Loading

Uh oh!

codecov bot commented Feb 26, 2021 •

edited

Loading

Uh oh!

Borda left a comment •

edited

Loading

Uh oh!

chizuchizu commented Feb 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchaton left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

chizuchizu commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Issue

CHANGE

Before submitting

PR review

Did you have fun?

Uh oh!

codecov bot commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Borda left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chizuchizu commented Feb 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchaton left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

chizuchizu commented Feb 26, 2021 •

edited

Loading

codecov bot commented Feb 26, 2021 •

edited

Loading

Borda left a comment •

edited

Loading