Skip to content

Remove deprecated method ClusterEnvironment.creates_children#10339

Merged
carmocca merged 4 commits intomasterfrom
feature/remove-creates-children
Nov 4, 2021
Merged

Remove deprecated method ClusterEnvironment.creates_children#10339
carmocca merged 4 commits intomasterfrom
feature/remove-creates-children

Conversation

@awaelchli
Copy link
Copy Markdown
Contributor

@awaelchli awaelchli commented Nov 3, 2021

What does this PR do?

Part of #10312
Follow up to #10106

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added feature Is an improvement or enhancement breaking change Includes a breaking change labels Nov 3, 2021
@awaelchli awaelchli added this to the v1.6 milestone Nov 3, 2021
@awaelchli awaelchli marked this pull request as ready for review November 4, 2021 00:37
ananthsub
ananthsub approved these changes Nov 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a github label for cluster environments?

@mergify mergify bot added the ready to be merged PRs ready to be merged label Nov 4, 2021
@four4fish
Copy link
Copy Markdown
Contributor

four4fish commented Nov 4, 2021

qq: we can start remove 1.6 removable items right after 1.5 release?

@awaelchli
Copy link
Copy Markdown
Contributor Author

awaelchli commented Nov 4, 2021 •
edited
Loading

Is your question about the short deprecation time of this method?
Normally we have a two version jump, e.g., from 1.5 to 1.7. Here we did only one so that's why I'm removing it already.
If it's a concern, we can also hold off one more release and increase the deprecation one version.

@carmocca carmocca enabled auto-merge (squash) November 4, 2021 16:51
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2021

Codecov Report

Merging #10339 (325a5d4) into master (c5d011c) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10339   +/-   ##
=======================================
- Coverage      93%      93%   -0%     
=======================================
  Files         181      181           
  Lines       16496    16492    -4     
=======================================
- Hits        15270    15266    -4     
  Misses       1226     1226

@carmocca carmocca merged commit 3664659 into master Nov 4, 2021
@carmocca carmocca deleted the feature/remove-creates-children branch November 4, 2021 17:11
@zdenek-syntensor zdenek-syntensor mentioned this pull request Nov 5, 2021
Closed
@awaelchli awaelchli mentioned this pull request Nov 8, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@ananthsub ananthsub ananthsub approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change Includes a breaking change feature Is an improvement or enhancement ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@awaelchli @four4fish @ananthsub @carmocca @justusschock