Skip to content

[MNT] CI action for installing uv/uvx#654

Merged
robertmartin8 merged 3 commits intoPyPortfolio:mainfrom
tschm:action
Nov 11, 2025
Merged

[MNT] CI action for installing uv/uvx#654
robertmartin8 merged 3 commits intoPyPortfolio:mainfrom
tschm:action

Conversation

@tschm
Copy link
Contributor

@tschm tschm commented Nov 10, 2025

Also remove a lost workflow in the ISSUE_Template.

@tschm
Copy link
Contributor Author

tschm commented Nov 10, 2025

@fkiraly here I create an action I will later use within workflows. This action installs uv/uvx and task. It also creates the virtual environment using a parametrized parameter version. This is very useful! It also removes a workflow that was hidden in the ISSUE_Templates?!

This composite action sets up a Python project by installing necessary tools, creating a virtual environment, and checking for the presence of a pyproject.toml file.
@tschm
Copy link
Contributor Author

tschm commented Nov 10, 2025

@fkiraly This should be good to merge. The action isn't used at this stage but will soon play a role during ci/cd

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-principle ok direction-wise, we should just make sure that PR fully replace a functionality with another (e.g., pip based with uv based CI) and do not completely remove it.

The reason is, multiple developers may work on this repository and some may have forked it.

We do not want to have a broken state of CI on main at all if we can avoid it, and if we cannot, it should be limited to minutes if possible.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Nov 10, 2025
@fkiraly fkiraly changed the title Introduce an action installing uv/uvx and task [MNT] CI action for installing uv/uvx Nov 10, 2025
@robertmartin8 robertmartin8 merged commit 4f116ce into PyPortfolio:main Nov 11, 2025
18 checks passed
@tschm
Copy link
Contributor Author

tschm commented Nov 11, 2025

Of course, main shall remain green at all stages. However, people may have to rebase their branches once in a while. Happy to write a few lines how to rebase with respect to an upstream repo

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 13, 2025

no, let´s please not use rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants