Conversation
|
@fkiraly All tests seem to work here?! The Dockerfile is obsolete. Later we could have .devcontainer which is much easier to use... |
fkiraly
left a comment
There was a problem hiding this comment.
Hm, what if someone still relies on this? We need to think about the principle "do not delete working code".
Can we safely remove it?
|
It's very non-standard that a package would have its own Dockerfile in 2025. This was initially introduced to ensure developers work in an homogeneous environment. This task is now much better solved with .devcontainers. Of course, the Dockerfile is very simplisitc and any user can install the package in a Dockerimage if they really want to. We also don't publish the related image let alone build or test it. Better remove. |
fkiraly
left a comment
There was a problem hiding this comment.
Ok, I can live with that. @robertmartin8 may also like to comment.
This dockerfile introduced by tschm is really no longer needed. We will work on a modern .devcontainer setup