Skip to content

Change start_side argument of PullRequest.create_review_comment from int to str#3170

Merged
EnricoMi merged 2 commits intoPyGithub:mainfrom
ryanpeach:hotfix/start_side_str
Feb 14, 2025
Merged

Change start_side argument of PullRequest.create_review_comment from int to str#3170
EnricoMi merged 2 commits intoPyGithub:mainfrom
ryanpeach:hotfix/start_side_str

Conversation

@ryanpeach
Copy link
Copy Markdown
Contributor

@ryanpeach ryanpeach commented Jan 9, 2025

Fixes #3169

@EnricoMi EnricoMi changed the title int to str on start_side Change start_side argument of PullRequest.create_review_comment from int to str Feb 3, 2025
Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi added this pull request to the merge queue Feb 14, 2025
Merged via the queue into PyGithub:main with commit f814de7 Feb 14, 2025
13 checks passed
@EnricoMi EnricoMi added bug breaking A breaking change bugfix and removed bug breaking A breaking change labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start_side should be str

2 participants