These expiration timestamps are evaluated server-side. I think there is no issue with the tests past this time.

Have you tested this breaks with local time changed past that date?

Yes, that is how I found this.

 =================================== FAILURES ===================================
 _____________ Authentication.testAppInstallationAuthAuthentication _____________
 
 self = <tests.Authentication.Authentication testMethod=testAppInstallationAuthAuthentication>
 
     def testAppInstallationAuthAuthentication(self):
         # test data copied from testAppAuthentication to test parity
         installation_auth = github.Auth.AppInstallationAuth(self.app_auth, 29782936)
         g = github.Github(auth=installation_auth)
     
         # test token expiry
         # token expires 2024-11-25 01:00:02
         token = installation_auth.token
 >       self.assertFalse(installation_auth._is_expired)
 E       AssertionError: True is not false
 
 tests/Authentication.py:182: AssertionError
 =========================== short test summary info ============================
 FAILED tests/Authentication.py::Authentication::testAppInstallationAuthAuthentication
 ======================== 1 failed, 936 passed in 31.00s ========================

Then we should mock the clock used by _is_expired:

diff --git a/tests/Authentication.py b/tests/Authentication.py
index ffd419c6..071a2147 100644
--- a/tests/Authentication.py
+++ b/tests/Authentication.py
@@ -176,16 +176,15 @@ class Authentication(Framework.BasicTestCase):
         installation_auth = github.Auth.AppInstallationAuth(self.app_auth, 29782936)
         g = github.Github(auth=installation_auth)
 
-        # test token expiry
         # token expires 2024-11-25 01:00:02
         token = installation_auth.token
-        self.assertFalse(installation_auth._is_expired)
         self.assertEqual(
             installation_auth._AppInstallationAuth__installation_authorization.expires_at,
             datetime(2024, 11, 25, 1, 0, 2, tzinfo=timezone.utc),
         )
 
-        # forward the clock so token expires
+        # test token expiry
+        # control the current time used by _is_expired
         with mock.patch("github.Auth.datetime") as dt:
             # just before expiry
             dt.now = mock.Mock(return_value=datetime(2024, 11, 25, 0, 59, 3, tzinfo=timezone.utc))

OK. I can test your patch.

I tried that patch and got a different error/trace:
https://rb.zq1.de/other/python-PyGithub/pr3045-log1.txt

There is around one month left to solve this. What are the plans?

I tried that patch and got a different error/trace: https://rb.zq1.de/other/python-PyGithub/pr3045-log1.txt

Probably because you did not revert your changes of the replay data.

Reverting your commit and applying the proposed patch fixes the issue.

You can have a look at
https://rb.zq1.de/other/python-PyGithub/build-log-0c41ff94d.txt
in line 85 you see that it runs 13 months from now with -rtc base=2025-11-26
in line 656, you can see that only 0c41ff9.patch gets applied
and in line 3552 you can see the failed assertion.

It does not throw the assertion with the current date.

Looking more closely at the test log, the problem seems to be that it tries to connect a live server, but our builds run without access to the internet. So maybe something wrong with the mocking?

Of course, using the token has to be guarded against real time as well: 6898f52

How is this now?

Yes, that makes it pass.

Can we please get a new release well ahead of 2024-11-25 ?

Why is that?

So that we (openSUSE and all other distributions) don't need to cherry-pick this patch onto our 2.4.0 package.

Do you execute unit tests in your pipeline?

Yes: https://src.opensuse.org/rpm/python-PyGithub/src/branch/factory/python-PyGithub.spec#L73

Released as v2.5.0.