Add minimize and unminimize functions for IssueComment class#3005
Merged
EnricoMi merged 9 commits intoPyGithub:mainfrom Jul 29, 2024
Merged
Add minimize and unminimize functions for IssueComment class#3005EnricoMi merged 9 commits intoPyGithub:mainfrom
EnricoMi merged 9 commits intoPyGithub:mainfrom
Conversation
EnricoMi
approved these changes
Jul 25, 2024
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
LGTM! Looks like we need GraphQL testing capabilities in this project.
EnricoMi
requested changes
Jul 28, 2024
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
Looks like there is testing available. Can you add some tests for those two new IssueComment methods?
Contributor
Author
I added the tests. Are they enough? |
Collaborator
|
I have added missing test data. |
Contributor
Author
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds two new functions,
minimizeandunminimize, to theIssueCommentclass. These functions allow users to minimize and unminimize comments using the GitHub GraphQL API. Theminimizefunction takes an optional reason parameter and sends a mutation to minimize the comment. Theunminimizefunction sends a mutation to unminimize the comment. These functions provide more control and flexibility for managing comments in GitHub issues.