Merged
Conversation
b0c6f91 to
c2ae2e7
Compare
Requester hands over the headers to Authentication classes for adding authentication
c2ae2e7 to
294e68a
Compare
EnricoMi
requested changes
Jul 29, 2024
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
Excellent refactoring! Can you move the code from tests/Issue2971.py into tests/Authentication.py?
Contributor
Author
|
Thanks for the package. It made our life a lot easier. I moved the tests according to your request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requester hands over the headers to Authentication classes for adding authentication.
Thus a consumer of this package is able to implement any kind of authentication done in the headers.
This should resolve #2971.