Skip to content

Fix building PyGithub with extra directories in source root#2894

Merged
EnricoMi merged 1 commit intoPyGithub:mainfrom
treee111:fix-build-with-temp-dir
Feb 5, 2024
Merged

Fix building PyGithub with extra directories in source root#2894
EnricoMi merged 1 commit intoPyGithub:mainfrom
treee111:fix-build-with-temp-dir

Conversation

@treee111
Copy link
Copy Markdown
Contributor

@treee111 treee111 commented Feb 5, 2024

@treee111
Copy link
Copy Markdown
Contributor Author

treee111 commented Feb 5, 2024

feel free to test if this also works in your environment @kloczek

@EnricoMi EnricoMi changed the title fixes a temporary directory in source tree to crash building PyGithub Fix building PyGithub with extra directories in source root Feb 5, 2024
Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi
Copy link
Copy Markdown
Collaborator

EnricoMi commented Feb 5, 2024

Tested locally, fixes the issue.

@EnricoMi EnricoMi merged commit 4d46173 into PyGithub:main Feb 5, 2024
@EnricoMi
Copy link
Copy Markdown
Collaborator

EnricoMi commented Feb 5, 2024

@treee111 thanks for fixing this!

@kloczek
Copy link
Copy Markdown

kloczek commented Feb 5, 2024

feel free to test if this also works in your environment @kloczek

Just tested that and it works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.2.0] Extra directory in source tree trashes build

3 participants