Add missing attributes to BranchProtection Jan 2024#2793
Add missing attributes to BranchProtection Jan 2024#2793jodelasur wants to merge 4 commits intoPyGithub:mainfrom
BranchProtection Jan 2024#2793Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
=======================================
Coverage 96.69% 96.70%
=======================================
Files 142 142
Lines 14533 14568 +35
=======================================
+ Hits 14053 14088 +35
Misses 480 480 ☔ View full report in Codecov by Sentry. |
EnricoMi
left a comment
There was a problem hiding this comment.
While you are there, can you add all other missing attributes as well, please?
https://docs.github.com/en/rest/branches/branch-protection#get-branch-protection
required_conversation_resolution to BranchProtectionBranchProtection Jan 2024
|
"Hi @jodelasur, we're interested in adopting these functionalities. Could you expedite the merging of the pull requests, or do you have any suggestions for directly incorporating these modules? Thanks!" |
|
@JayChanggithub , waiting for further review from @EnricoMi to have this merged. |
|
also fixes #2373 in my opinion. well, maybe not fully... question @jodelasur:
or also editing branch protection for these fields via e.g.
while testing for me it seams that only 1. is added with this PR |
|
Superseded by #2873, added you as co-author to appreciate your contribution. |
Fixes #2862. Also added other missing attributes.
All attributes added:
allow_force_pushesallow_deletionsrequired_conversation_resolutionlock_branchallow_fork_syncingUsed
scripts/add_attributeand added attribute tests accordingly using existing replay data.