Skip to content

Support oauth for enterprise#2780

Merged
JLLeitschuh merged 3 commits intoPyGithub:mainfrom
EnricoMi:oauth-enterprise
Mar 21, 2024
Merged

Support oauth for enterprise#2780
JLLeitschuh merged 3 commits intoPyGithub:mainfrom
EnricoMi:oauth-enterprise

Conversation

@EnricoMi
Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi commented Oct 3, 2023

Fixes #2766, fixes #2485.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 3, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.74%. Comparing base (d65fc30) to head (e9001e6).
⚠️ Report is 261 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2780   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         147      147           
  Lines       14962    14978   +16     
=======================================
+ Hits        14475    14491   +16     
  Misses        487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EnricoMi EnricoMi requested a review from JLLeitschuh March 9, 2024 19:31
Copy link
Copy Markdown
Collaborator

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi
Copy link
Copy Markdown
Collaborator Author

Thanks @JLLeitschuh!

@JLLeitschuh JLLeitschuh merged commit e4106e0 into PyGithub:main Mar 21, 2024
@EnricoMi EnricoMi deleted the oauth-enterprise branch March 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github enterprise -- app.get_access_token fails on Requester.py __makeAbsoluteUrl assertions. Support Oauth apps with Github Enterprise

3 participants