Add missing attributes to Repository #2742
Conversation
|
Hi @trim21 ! Let me know if I need to do anything else to get this feature merged :) I hope I did things properly |
EnricoMi
left a comment
There was a problem hiding this comment.
While you are adding a missing attribute, can you add those that are also missing, e.g.
- is_template
- use_squash_pr_title_as_default
- squash_merge_commit_title
- squash_merge_commit_message
- merge_commit_title
- merge_commit_message
- web_commit_signoff_required
Please check if I missed some.
visibility in Repository.edit()visibility in Repository
|
Yep, for sure @EnricoMi - let me do that! =) |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 139 139
Lines 14129 14192 +63
=======================================
+ Hits 13768 13830 +62
- Misses 361 362 +1
☔ View full report in Codecov by Sentry. |
|
@EnricoMi - changes have been addressed - I have also updated removed arguments (like |
visibility in RepositoryRepository.edit(...)
EnricoMi
left a comment
There was a problem hiding this comment.
Can we get add all those new attributes to _initAttributes and _useAttributes and create getters as well? Please record test data for testAttributes and add those attributes there as well.
|
Hi @EnricoMi - issues addressed. I added the properties, initialized the attributes and modified the useAttributes function. I also updated the test data. I hope everything is fine now. Let me know if you need anything else |
|
Nice work @RobPasMue . Thanks for updating the properties according to the API. |
Repository.edit(...) Repository
|
Thanks @EnricoMi! Appreciated your feedback and merging! |
According to https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#update-a-repository
New parameters are accepted and others have been removed.
Parameters included in this PR:
visibilityis_templateuse_squash_pr_title_as_defaultsquash_merge_commit_titlesquash_merge_commit_messagemerge_commit_titlemerge_commit_messageweb_commit_signoff_requiredParamters removed in this PR:
has_downloadsParameters have also been ordered according to the REST API order in the documentation