feat: manage require_last_push_approval and allow_deletions in branch protection#2716
Closed
terenho wants to merge 6 commits intoPyGithub:mainfrom
Closed
feat: manage require_last_push_approval and allow_deletions in branch protection#2716terenho wants to merge 6 commits intoPyGithub:mainfrom
terenho wants to merge 6 commits intoPyGithub:mainfrom
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
==========================================
- Coverage 96.74% 96.73% -0.01%
==========================================
Files 139 139
Lines 14184 14214 +30
==========================================
+ Hits 13722 13750 +28
- Misses 462 464 +2
☔ View full report in Codecov by Sentry. |
82d98c4 to
17a1a18
Compare
EnricoMi
requested changes
Aug 21, 2023
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
Can we have tests for the new fields?
ffc42cf to
6badde8
Compare
Contributor
Author
Added/updated tests for the new fields in the latest commits |
6badde8 to
4f7820d
Compare
Contributor
Author
|
@EnricoMi I have added the allow_deletion function and added tests, I also resolved a merge conflict. This PR is ready for review. |
This was referenced Jan 15, 2024
Collaborator
|
Superseded by #2873, added you as co-author to appreciate your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2360