Add Secret and Variable classes by nthings · Pull Request #2623 · PyGithub/PyGithub

nthings · 2023-07-13T17:20:01Z

Hi! this PR is for adding the Secret and Variable classes. Before I added the variable methods to Organization and Repository but I think is better handling this way. Let me know feedback if this is good so I can start adding test cases. Ty!

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

codecov-commenter · 2023-07-25T16:55:48Z

Codecov Report

❌ Patch coverage is 82.06278% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.48%. Comparing base (7cfa476) to head (40fc3f2).
⚠️ Report is 380 commits behind head on main.

Files with missing lines	Patch %	Lines
github/OrganizationSecret.py	74.50%	13 Missing ⚠️
github/OrganizationVariable.py	74.50%	13 Missing ⚠️
github/Repository.py	66.66%	5 Missing ⚠️
github/Variable.py	90.00%	5 Missing ⚠️
github/Secret.py	89.18%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
- Coverage   97.72%   97.48%   -0.24%     
==========================================
  Files         132      136       +4     
  Lines       13568    13745     +177     
==========================================
+ Hits        13259    13399     +140     
- Misses        309      346      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trim21 · 2023-07-25T16:57:17Z

Please see 8bdfc3a for some examples how to inline typing into the .py file.

nthings · 2023-07-25T17:12:05Z

Addressed most of comments can I get a re-review? @EnricoMi @trim21 Also bit of help needed into the implementation of PaginatedList on the selected_repositories property

github/OrganizationVariable.py

trim21 · 2023-07-25T18:19:42Z

Sorry, I mean to move _initAttributes, and make it the first method of class, don't move __repr__

nthings · 2023-07-25T18:26:45Z

Sorry, I mean to move _initAttributes, and make it the first method of class, don't move __repr__

Ok. Below the properties right?

trim21 · 2023-07-25T19:06:23Z

Sorry, I mean to move _initAttributes, and make it the first method of class, don't move __repr__

Ok. Below the properties right?

class ...:

_initAttributes

__repr__

others

_useAttributes

nthings · 2023-07-26T17:00:44Z

@trim21 reordered those methods. Do you have example of a class that one of the properties is a PaginatedList?

trim21 · 2023-07-26T17:19:57Z

@trim21 reordered those methods. Do you have example of a class that one of the properties is a PaginatedList?

PyGithub/github/MainClass.py

Lines 262 to 270 in 13e178a

    
               def get_licenses(self): 
        
                   """ 
        
                   :calls: `GET /licenses <https://docs.github.com/en/rest/reference/licenses#get-all-commonly-used-licenses>`_ 
        
                   :rtype: :class:`github.PaginatedList.PaginatedList` of :class:`github.License.License` 
        
                   """ 
        
                   url_parameters = dict() 
        
                   return github.PaginatedList.PaginatedList(github.License.License, self.__requester, "/licenses", url_parameters)

nthings · 2023-07-27T18:56:10Z

@trim21 I think I got it working. Please let me know any feedback so I can go ahead with test cases

EnricoMi

LGTM!

Ideally, we would have tests for get_secret, get_secrets, create_secrets, get_variable, get_variables and create_variables on Organization and Repository, assert all attributes of Secret, OrganizationSecret and Variable (at least in one test), and call selected_repositories on OrganizationSecret and OrganizationVariable.

nthings · 2023-08-10T02:52:58Z

@EnricoMi @trim21 Test cases added!

EnricoMi

LGTM!

Mauricio Martinez and others added 30 commits June 28, 2023 13:02

Adding support for actions variables repo and org level

a055b72

Merge branch 'main' into main

5324802

Fix replay data

77f7dfd

Merge branch 'main' of https://github.com/PyGithub/PyGithub

4f7be28

Merge branch 'main' of https://github.com/nthings/PyGithub

a275104

Merge branch 'main' into main

b6c1f27

Add types

6f28ea8

Add types

65137df

Add support for list type and fix CI

4dfae63

Lint black

9c37df9

Lint black

d91ab9b

Rollback Framework change due to black

7ba4df3

Rollback RepositoryAdvisoryVulnerability change due to black

23c9255

Merge branch 'main' into main

96750a8

Merge branch 'main' into main

fce0414

Merge branch 'main' of https://github.com/PyGithub/PyGithub

53237b9

Move tests to main files

3e7a597

Merge branch 'main' of https://github.com/nthings/PyGithub

5ce32a8

Adding my name to the tests

c632763

lint

06996d3

Update github/Organization.py

6039386

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

Update github/Organization.py

2dbea8f

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

Merge branch 'main' into main

f73971c

Empty-Commit

52befd6

Merge branch 'main' of https://github.com/PyGithub/PyGithub

1342c5d

Adding Secret and Variable classes

66cc840

Lint

b895712

Update pyi

b10565d

Merge branch 'main' into main

3cfeccb

Lint

8da051b

Mauricio Martinez added 2 commits July 25, 2023 08:39

Pre-commit

d40d00e

Fix tests and lint

85077ca

Fix tests and lint

9379d8d

trim21 suggested changes Jul 25, 2023

View reviewed changes

github/OrganizationVariable.py Outdated Show resolved Hide resolved

Moving __repr__ method

0acd21f

Rearanging methods

ff7c7a4

Rearanging methods

90ae26c

Mauricio Martinez added 2 commits July 27, 2023 09:53

Fixing mypy errors

f9d2131

removing selected_repositories from org classes because own methods

db70d06

nthings requested a review from trim21 July 31, 2023 14:51

Merge branch 'main' into main

1a0f424

EnricoMi approved these changes Aug 9, 2023

View reviewed changes

Mauricio Alejandro Martínez Pacheco added 2 commits August 9, 2023 11:28

Merge branch 'main' into main

26e7dbf

Adding test cases

40fc3f2

EnricoMi approved these changes Aug 10, 2023

View reviewed changes

EnricoMi merged commit bcca758 into PyGithub:main Aug 10, 2023

Uh oh!

Conversation

nthings commented Jul 13, 2023

Uh oh!

codecov-commenter commented Jul 25, 2023 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trim21 commented Jul 25, 2023

Uh oh!

nthings commented Jul 25, 2023

Uh oh!

Uh oh!

trim21 commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nthings commented Jul 25, 2023

Uh oh!

trim21 commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nthings commented Jul 26, 2023

Uh oh!

trim21 commented Jul 26, 2023

Uh oh!

nthings commented Jul 27, 2023

Uh oh!

EnricoMi left a comment

Choose a reason for hiding this comment

Uh oh!

nthings commented Aug 10, 2023

Uh oh!

EnricoMi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jul 25, 2023 •

edited by codecov bot

Loading

trim21 commented Jul 25, 2023 •

edited

Loading

trim21 commented Jul 25, 2023 •

edited

Loading