[CI] support mypy/pytest github pr annotations#2522
[CI] support mypy/pytest github pr annotations#2522EnricoMi merged 21 commits intoPyGithub:masterfrom trim21:ci-lint
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2522 +/- ##
==========================================
- Coverage 98.49% 98.48% -0.02%
==========================================
Files 128 128
Lines 12733 12612 -121
==========================================
- Hits 12542 12421 -121
Misses 191 191 ☔ View full report in Codecov by Sentry. |
| @@ -7,7 +7,7 @@ envlist = | |||
| [gh-actions] | |||
| python = | |||
There was a problem hiding this comment.
Looks like this list is useless, when running tox on github actions with python versions that are not listed her still runs them:
- 3.12-dev: https://github.com/PyGithub/PyGithub/actions/runs/5259774567/jobs/9505791611#step:5:26
- 3.11: https://github.com/PyGithub/PyGithub/actions/runs/5259774567/jobs/9505791522#step:5:26
So what is the point in maintaining this list?
There was a problem hiding this comment.
oh， this make sure on ci job only run tests once
There was a problem hiding this comment.
right, I guess one entry is sufficient then (plus a comment why this is there)
There was a problem hiding this comment.
Wait, I'll test if it will run multiple tests in one ci job.
There was a problem hiding this comment.
This is necessary.
comment added, also notice developer to keep python version in ci and tox.ini synced
EnricoMi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for tightening this!
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
|
Thanks a lot! |
Now we want to add inlint type annotation, this would be very useful
also add pytest-github-actions-annotate-failures for pytest
https://github.com/pytest-dev/pytest-github-actions-annotate-failures