Skip to content

fix: Repository.get_artifact() missing argument artifact_id#2458

Merged
EnricoMi merged 2 commits intoPyGithub:masterfrom
trim21:fix-repo-get-artifact
May 13, 2023
Merged

fix: Repository.get_artifact() missing argument artifact_id#2458
EnricoMi merged 2 commits intoPyGithub:masterfrom
trim21:fix-repo-get-artifact

Conversation

@trim21
Copy link
Contributor

@trim21 trim21 commented Mar 19, 2023

PyGithub/github/Repository.py

Lines 3778 to 3784 in 822fc05

def get_artifact(self, artifact_id):
"""
:calls: `GET /repos/{owner}/{repo}/actions/artifacts/{artifact_id} <https://docs.github.com/en/rest/actions/artifacts#get-an-artifact>`_
:param artifact_id: int
:rtype: :class:`github.Artifact.Artifact`
"""
assert isinstance(artifact_id, int), artifact_id

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10 🎉

Comparison is base (17cd0b7) 98.67% compared to head (efa8eba) 98.77%.

❗ Current head efa8eba differs from pull request most recent head d1cee95. Consider uploading reports for the commit d1cee95 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
+ Coverage   98.67%   98.77%   +0.10%     
==========================================
  Files         117      117              
  Lines       11764    11689      -75     
==========================================
- Hits        11608    11546      -62     
+ Misses        156      143      -13     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trim21
Copy link
Contributor Author

trim21 commented May 13, 2023

ha! didn't notice the syntax is wrong

@EnricoMi EnricoMi merged commit 4fa0a5f into PyGithub:master May 13, 2023
@trim21 trim21 deleted the fix-repo-get-artifact branch May 13, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants