Skip to content

Propagate ssl verify (just like base_url)#2455

Closed
goldstar611 wants to merge 5 commits intoPyGithub:masterfrom
goldstar611:propogate_ssl_verify
Closed

Propagate ssl verify (just like base_url)#2455
goldstar611 wants to merge 5 commits intoPyGithub:masterfrom
goldstar611:propogate_ssl_verify

Conversation

@goldstar611
Copy link

@goldstar611 goldstar611 commented Mar 15, 2023

It's common to have a custom root CA for self hosted github enterprise installations. Propogate the verify parameter just like base_url parameter.

#2447

@EnricoMi
Copy link
Collaborator

Just like base_url and verify, the Requester inside GithubIntegration should also populate

  • timeout
  • user_agent
  • per_page
  • retry
  • pool_size

Duplicating the arguments passed to Requester.__init__ in GithubIntegration.__init__ just feels like this needs some thorough refactoring.

@goldstar611
Copy link
Author

goldstar611 commented Mar 16, 2023

I'm up for moving and propagating those parameters in this PR but agree with you that there should be a better way. If python provided a way to override values in the constants file that would be ideal.

Since I knew that the verify changes were lined up for the next release I thought a fix for those who use self signed certs for their github enterprise installation could also make it in together.

Let me know what you want to see here and I'll work on it.

@goldstar611 goldstar611 changed the title Propogate ssl verify (just like base_url) Propagate ssl verify (just like base_url) Mar 17, 2023
@goldstar611 goldstar611 deleted the propogate_ssl_verify branch March 17, 2023 15:51
@goldstar611
Copy link
Author

whoops, I renamed the branch to correct a typo (propagate) and the PR closed here. But do let me know if verify was enough on its own or if all of those variables should be propagated.

@EnricoMi
Copy link
Collaborator

I think there should be one entry point that takes verify, base_url, ..., rather than duplicating those. Further, there are some existing issues around expired JWT tokens. Please see description and first approach in #2461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants