Skip to content

Mark Issue.pull_request type as Optional#2421

Closed
jwodder wants to merge 1 commit intoPyGithub:mainfrom
jwodder:issue-pr-opt
Closed

Mark Issue.pull_request type as Optional#2421
jwodder wants to merge 1 commit intoPyGithub:mainfrom
jwodder:issue-pr-opt

Conversation

@jwodder
Copy link
Contributor

@jwodder jwodder commented Feb 15, 2023

Issue.pull_request can be None when the issue is not also a pull request, and so its type annotation should be Optional[IssuePullRequest].

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 98.77% // Head: 98.77% // No change to project coverage 👍

Coverage data is based on head (a4f7b94) compared to base (5e27c10).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2421   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         117      117           
  Lines       11674    11674           
=======================================
  Hits        11531    11531           
  Misses        143      143           
Impacted Files Coverage Δ
github/Repository.py 97.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants