Skip to content

Feat: Add missing branch protection fields incl. lock_branch#2378

Closed
harry-unlikelyai wants to merge 7 commits intoPyGithub:mainfrom
harry-unlikelyai:complete-branch-protection-lock-bracnh
Closed

Feat: Add missing branch protection fields incl. lock_branch#2378
harry-unlikelyai wants to merge 7 commits intoPyGithub:mainfrom
harry-unlikelyai:complete-branch-protection-lock-bracnh

Conversation

@harry-unlikelyai
Copy link
Contributor

@harry-unlikelyai harry-unlikelyai commented Dec 9, 2022

Fixes #2373

Add new BranchProtection options listed here: https://developer.github.com/v3/repos/branches/

required_linear_history
allow_force_pushes
allow_deletions
lock_branch

Replica of #1723 and #2376 but also adds lock_branch.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022 •
edited
Loading

Codecov Report

Base: 98.75% // Head: 98.62% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (1d0a7dc) compared to base (7902351).
Patch coverage: 63.63% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
- Coverage   98.75%   98.62%   -0.14%     
==========================================
  Files         115      115              
  Lines       11578    11622      +44     
==========================================
+ Hits        11434    11462      +28     
- Misses        144      160      +16
Impacted Files Coverage Δ
github/BranchProtection.py 82.27% <57.14%> (-13.80%) ⬇️
github/Branch.py 90.90% <75.00%> (-1.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@harry-unlikelyai harry-unlikelyai mentioned this pull request Dec 9, 2022
Closed
@martinmosegaard
Copy link

martinmosegaard commented Dec 13, 2022

Is it possible to add require_last_push_approval in this PR as well?

@harry-unlikelyai
Copy link
Contributor Author

harry-unlikelyai commented Dec 14, 2022

@martinmosegaard Ok added that too now

@martinmosegaard
Copy link

martinmosegaard commented Dec 14, 2022

Thanks! It is mentioned on https://docs.github.com/en/rest/branches/branch-protection?apiVersion=2022-11-28 fwiw.

@harry-unlikelyai
Copy link
Contributor Author

harry-unlikelyai commented Dec 14, 2022

Ah interesting, I had added it in the wrong way then since it needs to be part of the required_pull_request_reviews object

@kgal-pan kgal-pan mentioned this pull request Nov 22, 2023
Closed
@treee111 treee111 mentioned this pull request Jan 15, 2024
Closed
@treee111
Copy link
Contributor

treee111 commented Jan 15, 2024

Hi @harry-unlikelyai, you have conflicts with the base branch. PR's 2793 and 2716 have also the same field allow_deletions, see my comment

@treee111 treee111 mentioned this pull request Jan 16, 2024
Merged
@EnricoMi
Copy link
Collaborator

EnricoMi commented Jan 23, 2024

Superseded by #2873, added you as co-author to appreciate your contribution.

@EnricoMi EnricoMi closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

github.BranchProtection.BranchProtection missing 3 attributes

6 participants

@harry-unlikelyai @codecov-commenter @martinmosegaard @treee111 @EnricoMi @ruben-chainalysis