Adjust to Github API changes regarding emails#1890
Merged
s-t-e-v-e-n-k merged 2 commits intoPyGithub:masterfrom Mar 24, 2021
Merged
Adjust to Github API changes regarding emails#1890s-t-e-v-e-n-k merged 2 commits intoPyGithub:masterfrom
s-t-e-v-e-n-k merged 2 commits intoPyGithub:masterfrom
Conversation
s-t-e-v-e-n-k
requested changes
Mar 23, 2021
Collaborator
s-t-e-v-e-n-k
left a comment
There was a problem hiding this comment.
This is looking like a great start, I have some concerns inline.
ac86ebe to
85cc405
Compare
a13f6df to
9c0c522
Compare
tests/AuthenticatedUser.py
Outdated
| def testEmails(self): | ||
| self.assertEqual( | ||
| self.user.get_emails(), | ||
| [item.email for item in self.user.get_emails()], |
Collaborator
There was a problem hiding this comment.
You probably need to pull this out of the list comprehension so you check at least primary and hopefully the other two for the first element.
s-t-e-v-e-n-k
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1852