Skip to content

[CLONE] Separate request for requested reviewers #2348

@tisonkun

Description

@tisonkun

@sfdye The response of listing pull requests already contains the requested reviewers' information. However, currently, if you want to list all requested reviewers for all pull requests, you must first list all pull requests (a paginated query) and then list request reviewers one pr by another (N paginated query), while you should have implemented it with only one paginated query.

That is, you should be able to fulfill the field with:

        if "requested_reviewers" in attributes:
            self._requested_reviewers = self._makeIntAttribute(
                attributes["requested_reviewers"]
            )

Originally posted by @tisonkun in #679 (comment)

This can be a significant performance factor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions